Skip to content

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 1 | Feature-destructuring - #503

Open
Tobias-Amaechina wants to merge 6 commits into
CodeYourFuture:mainfrom
Tobias-Amaechina:feature/destructuring
Open

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 1 | Feature-destructuring#503
Tobias-Amaechina wants to merge 6 commits into
CodeYourFuture:mainfrom
Tobias-Amaechina:feature/destructuring

Conversation

@Tobias-Amaechina

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

print-1/destructuring/exercise-1/exercise.js
Adds object destructuring: let {name, age, favouriteFood} = personOne;
Leaves the exercise function signature placeholder in place
Sprint-1/destructuring/exercise-2/exercise.js
Adds two helper functions:
gryffindorOccupiers(hogwarts) — returns full names of people in Gryffindor using destructuring.
teachersWithPets(hogwarts) — returns teacher names who have pets (uses destructuring and a pet truthy check).
Sprint-1/destructuring/exercise-3/exercise.js
Adds a formatted receipt printout: destructures order items, computes line totals and a grand total, and logs a formatted table.
readme
Expands the module README with short bullets on where data can come from (hard‑coded, user input, files, APIs, DBs).

@github-actions

This comment has been minimized.

@Tobias-Amaechina Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@Tobias-Amaechina Tobias-Amaechina changed the title Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 1 |Feature/destructuring Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 1 | Feature-destructuring Jul 30, 2026
@github-actions

This comment has been minimized.

@Tobias-Amaechina Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@Tobias-Amaechina Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, 2/3. just something to check in the first task

let {name,age,favouriteFood} = personOne;
// Update the parameter to this function to make it work.
// Don't change anything else.
function introduceYourself(___________________________) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is asking to modify the function parameter, can you try this?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, the function has been modified as requested

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 3, 2026
@Tobias-Amaechina Tobias-Amaechina added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 3, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great,I hope it is clear how this is a better approach than making global variables

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🏕 Priority Mandatory This work is expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants